Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tmpl.ScanScript is ignored in Classic builds #3837

Open
isaak654 opened this issue Apr 21, 2024 · 1 comment
Open

Tmpl.ScanScript is ignored in Classic builds #3837

isaak654 opened this issue Apr 21, 2024 · 1 comment
Labels
Feature request New feature or idea help wanted Extra help is needed

Comments

@isaak654
Copy link
Collaborator

Is your feature request related to a problem or use case?

Tmpl.ScanScript is currently only available for Plus builds:

let scanScript = template.getIniValue('Tmpl.ScanScript');
if(scanScript){
let ret = false;
try{
ret = eval('(()=>{' + scanScript + '})()');
} catch (error) {
sbie.logMessage("error:" + error);
}
return ret;
}

Describe the solution you'd like

Considering its current use in Templates.ini, it would be appropriate to introduce it for Sandboxie Classic builds.

Describe alternatives you've considered

Provide a reason not to do so.

@isaak654 isaak654 added the Feature request New feature or idea label Apr 21, 2024
@DavidXanatos
Copy link
Member

This is not realistically feasible, we need a JavaScript engine, with Qt that's convenient as we use it for the troubleshooting wizard as well.
For classic its not reasonable to include for example the entire google V8 engine. Also the classic UI is deprecated we drag it along but not actively spend time on developing it.
We could opt for using a different script engine and then we would have to have all "Tmpl.ScanScript" doubled "Tmpl.ScanScriptJS", "Tmpl.ScanScriptXX" a good candidate would be squirrel script as it has a very small engine.
Or perhaps one could find a sufficiently compact JS engine: https://gist.github.com/guest271314/bd292fc33e1b30dede0643a283fadc6a and use it.
Anyhow I am not going to invest time in the old UI, if there is anyone willing to integrate a script engine and create all the required bindings, I can advice in that.

@DavidXanatos DavidXanatos added the help wanted Extra help is needed label Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request New feature or idea help wanted Extra help is needed
Projects
None yet
Development

No branches or pull requests

2 participants