Support private registries #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreimarinescu
approved these changes
Apr 13, 2023
davidrunger
reviewed
Apr 19, 2023
| let fetch = () => {}; | ||
|
|
||
| const replaceEnvVars = (str) => | ||
| str.replace(/\${([^}]+)}/g, (match, variableName) => process.env[variableName] || ''); |
There was a problem hiding this comment.
FYI, I am getting an error here when running sandworm audit:
❯ sandworm audit
Sandworm 🪱
Security and License Compliance Audit
⠋ Building dependency graph...
❌ Failed: str.replace is not a function
TypeError: str.replace is not a function
at replaceEnvVars (/Users/david/.nvm/versions/node/v18.12.1/lib/node_modules/@sandworm/audit/src/registry.js:9:7)
at /Users/david/.nvm/versions/node/v18.12.1/lib/node_modules/@sandworm/audit/src/registry.js:17:28
at Array.forEach (<anonymous>)
[...]
In my case, the error is happening because str is a boolean (true) rather than a string. (The key is "color").
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for private registries:
NPM_CONFIG_REGISTRYenv var or with config files.npmrcconfig files are read from$HOME/.npmrcand from the project pathinihas been added to read the config filesregistry=${REGISTRY_VAR})registry.jsfilenode-fetchhttp client has been added to handle all http requests more conciselyCloses #50