-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow RESPONSE_TIMEOUT to be disabled #2489
Comments
@Tronic and I have talked about an overhaul to timeouts. This is not going to land in the upcoming release, but is absolutely something I'm hoping to get into the end of Summer release. |
@GabrielCappelli Setting to |
Zero to denote infinity is IMO a bad idea, even if many do it. I've seen inf used quite a bit for this on Python, but |
Thanks for the responses. The I think the only warning with using We're only interested in disabling the RESPONSE_TIMEOUT so it should be fine for our use case. |
I believe the timeout polling function is canceled at the end of the connection, but granted, it could be entirely avoided when there are no timeouts at all. However, the no timeout situation should also be quite rare as it makes it trivial to crash your server if you don't implement timeouts or other limits yourself or externally. |
Yeah, I've thought about this in the past about how we could implement per-endpoint overrides. The difficulty is that the timers live outside of routing. |
Is your feature request related to a problem? Please describe.
I would like to be able to disable RESPONSE_TIMEOUT so I can have long requests running until completion.
Describe the solution you'd like
A common solution to disable timeouts is to set the value to 0.
Additional context
N/A
The text was updated successfully, but these errors were encountered: