Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move some code into internal directory #304

Closed
5 tasks done
sashabaranov opened this issue May 8, 2023 · 1 comment · Fixed by #325 or #329
Closed
5 tasks done

Move some code into internal directory #304

sashabaranov opened this issue May 8, 2023 · 1 comment · Fixed by #325 or #329
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@sashabaranov
Copy link
Owner

sashabaranov commented May 8, 2023 •
edited
Loading

The root directory of the project is pretty bloated, it would be nice if can move the following into the internal directory:

  • error_accumulator
  • request_builder
  • form_builder
  • unmarshaler
  • marshaller

Also, I don't think we need Makefile anymore given the CI setup.
@sashabaranov sashabaranov added good first issue Good for newcomers help wanted Extra attention is needed labels May 8, 2023
@liushuangls
Copy link
Contributor

There are some questions:

  1. error_accumulator use ErrorResponse if move to internal will be cycle import error
  2. request_builder_test.go depend on client.go if move to internal will be cycle import error
  3. I think Makefile is helpful in local run test or golangci-lint

Do you have any ideas?

@JiayueShi JiayueShi mentioned this issue May 15, 2023
Merged
vvatanabe added a commit to vvatanabe/go-openai that referenced this issue May 26, 2023
@vvatanabe
move marshaller and unmarshaler into internal pkg (sashabaranov#304)
a89eae0
@vvatanabe vvatanabe mentioned this issue May 26, 2023
Merged
vvatanabe added a commit to vvatanabe/go-openai that referenced this issue May 26, 2023
@vvatanabe
move marshaller and unmarshaler into internal pkg (sashabaranov#304)
de71388
vvatanabe added a commit to vvatanabe/go-openai that referenced this issue May 26, 2023
@vvatanabe
move marshaller and unmarshaler into internal pkg (sashabaranov#304)
dfcada8
sashabaranov pushed a commit that referenced this issue May 28, 2023
@vvatanabe
move marshaller and unmarshaler into internal pkg (#304) (#325)
62eb4be
@sashabaranov sashabaranov reopened this May 28, 2023
vvatanabe added a commit to vvatanabe/go-openai that referenced this issue May 28, 2023
@vvatanabe
move request_builder into internal pkg (sashabaranov#304)
f750d00
@vvatanabe vvatanabe mentioned this issue May 28, 2023
Merged
sashabaranov pushed a commit that referenced this issue May 31, 2023
@vvatanabe
move request_builder into internal pkg (#304) (#329)
61ba5f3 
* move request_builder into internal pkg (#304)

* add some test for internal.RequestBuilder

* add a test for openai.GetEngine
@sashabaranov sashabaranov reopened this May 31, 2023
vvatanabe added a commit to vvatanabe/go-openai that referenced this issue May 31, 2023
@vvatanabe
move error_accumulator into internal pkg (sashabaranov#304)
2c9d003
vvatanabe added a commit to vvatanabe/go-openai that referenced this issue May 31, 2023
@vvatanabe
move error_accumulator into internal pkg (sashabaranov#304)
15653fd
vvatanabe added a commit to vvatanabe/go-openai that referenced this issue Jun 1, 2023
@vvatanabe
add a test for ErrTooManyEmptyStreamMessages in stream_reader (sashab…
444c808 
…aranov#304)
sashabaranov pushed a commit that referenced this issue Jun 5, 2023
@vvatanabe
move error_accumulator into internal pkg (#304) (#335)
1394329 
* move error_accumulator into internal pkg (#304)

* move error_accumulator into internal pkg (#304)

* add a test for ErrTooManyEmptyStreamMessages in stream_reader (#304)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
2 participants
@sashabaranov @liushuangls