-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenAI Mock Server #31
Merged
sashabaranov
merged 5 commits into
sashabaranov:master
from
RobotSail:openai-test-server
Aug 11, 2022
Merged
Add OpenAI Mock Server #31
sashabaranov
merged 5 commits into
sashabaranov:master
from
RobotSail:openai-test-server
Aug 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleg <97077423+RobotSail@users.noreply.github.com>
Signed-off-by: Oleg <97077423+RobotSail@users.noreply.github.com>
Signed-off-by: Oleg <97077423+RobotSail@users.noreply.github.com>
sashabaranov
requested changes
Aug 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! My concerns here are mostly about
curl | sh
for golang-ci setup- golang-ci config strictness and related changes to make linter happy
Signed-off-by: Oleg <97077423+RobotSail@users.noreply.github.com>
RobotSail
force-pushed
the
openai-test-server
branch
from
August 3, 2022 14:50
6194027
to
2d74770
Compare
Signed-off-by: Oleg <97077423+RobotSail@users.noreply.github.com>
sashabaranov
approved these changes
Aug 11, 2022
Great work, thank you for the PR! 🔥 |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes:
EditsUsage
andCompletionsUsage
are removed andUsage
is created as a separate type incommon.go
CompletionRequest.Model
fieldNote: not all of the endpoints have been implemented with the mocked server yet, and we should continue to do so as more changes are iterated on in this project.
This PR aims to close out #30, however we should aim to increase the amount of testing done and add coverage data.