move error_accumulator into internal pkg (#304) #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #335 +/- ##
==========================================
+ Coverage 92.45% 92.97% +0.51%
==========================================
Files 18 17 -1
Lines 636 626 -10
==========================================
- Hits 588 582 -6
+ Misses 35 32 -3
+ Partials 13 12 -1
|
vvatanabe
changed the title
|
@sashabaranov I moved error_accumulator into internal pkg. Please check this PR. |
sashabaranov
reviewed
Jun 5, 2023
| } | ||
|
|
||
| respErr = stream.unmarshalError() | ||
| if respErr != nil { |
There was a problem hiding this comment.
All these tests might benefit from https://github.com/sashabaranov/go-openai/blob/master/internal/test/checks/checks.go
There was a problem hiding this comment.
@sashabaranov I see! I'll send you a PR to refactor the test in the near future.
sashabaranov
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving error_accumulator to the internal package causes circular import. To avoid this, the following commit removes the ErrorResponse dependency from error_accumulator.
2c9d003
Next, the following commit moved error_accumulator to the internal package.
15653fd
And add a test for ErrTooManyEmptyStreamMessages in stream_reader. (Just increased test coverage.)
444c808