Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Ada Model Name #45

Merged
merged 2 commits into from
Dec 16, 2022

Conversation

mtrefilek
Copy link
Contributor

Incorrectly labelled the Ada model.

@sauceman40 Please review. You are absolutely right though. I must have misread it. But, something must be broken on my end because I wasn't erroring...

Sorry for the inconvenience.

Copy link
Contributor

@sauceman40 sauceman40 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be consistent with the model's naming convention, I'd change AdaSimilarityV2 to AdaEmbeddingV2. Other than that, looks good!

Copy link
Contributor

@sauceman40 sauceman40 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! @sashabaranov can you please approve? I don't think I have write access here

@sashabaranov
Copy link
Owner

Folks, thank you so much 🙌🏻

@sashabaranov sashabaranov merged commit 1c20931 into sashabaranov:master Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants