feat: support direct bytes for file upload #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #568 +/- ##
==========================================
+ Coverage 98.35% 98.38% +0.03%
==========================================
Files 24 24
Lines 1276 1300 +24
==========================================
+ Hits 1255 1279 +24
Misses 15 15
Partials 6 6 ☔ View full report in Codecov by Sentry. |
maerlyn5
pushed a commit
to prassoai/go-openai
that referenced
this pull request
Nov 22, 2023
* feat: support direct bytes for file upload * add test for errors * add coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
CreateFilecurrently requires a "local" file which it reads from the filesystem and uploads. For various reasons, we require uploading bytes directly rather than relying on local filesystem.Describe your solution
Add
CreateFileByteswhich takes aFileBytesRequestthat allows directly passing a[]byte. This reuses the exstingCreateFormFileReaderpassing a*bytes.Readerdirectly.Tests
Added a test case to
files_api_test.go. Also validated that it works in a separate app.