Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing response fields for pagination #584

Conversation

albertpurnama
Copy link
Contributor

@albertpurnama albertpurnama commented Nov 15, 2023

Describe the change
Missing pagination parameters for new assistants list API

Describe your solution
Add missing parameters

Tests
Verified against endpoint

Additional context

curl https://api.openai.com/v1/threads/thread_abc123/messages \
  -H "Content-Type: application/json" \
  -H "Authorization: Bearer $OPENAI_API_KEY" \
  -H "OpenAI-Beta: assistants=v1"
{
  "object": "list",
  "data": [],
  "first_id": "msg_abc123",
  "last_id": "msg_abc456",
  "has_more": false
}

Issue: resolves #583
Similar PR: #571

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1846572) 98.38% compared to head (c2d2b4e) 98.38%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #584   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files          24       24           
  Lines        1300     1300           
=======================================
  Hits         1279     1279           
  Misses         15       15           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@sashabaranov sashabaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sashabaranov sashabaranov merged commit a130cfe into sashabaranov:master Nov 18, 2023
3 checks passed
maerlyn5 pushed a commit to prassoai/go-openai that referenced this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing pagination parameters for list message beta API
2 participants