Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(documentdb): fix private network support #2608

Merged
merged 3 commits into from
Jun 10, 2024

Conversation

jremy42
Copy link
Contributor

@jremy42 jremy42 commented Jun 7, 2024

close #2588

@jremy42 jremy42 force-pushed the bug/documentdb-fix-private-network branch from fbada8a to 45769e8 Compare June 7, 2024 14:55
@jremy42 jremy42 changed the title Bug/documentdb fix private network Bug(documentdb): fix private network Jun 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 6 lines in your changes missing coverage. Please review.

Project coverage is 71.02%. Comparing base (fe86049) to head (f590826).
Report is 87 commits behind head on master.

Files Patch % Lines
...al/services/documentdb/private_network_endpoint.go 90.90% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2608      +/-   ##
==========================================
- Coverage   71.43%   71.02%   -0.42%     
==========================================
  Files         277      332      +55     
  Lines       35875    33244    -2631     
==========================================
- Hits        25628    23610    -2018     
+ Misses       8028     7328     -700     
- Partials     2219     2306      +87     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jremy42 jremy42 force-pushed the bug/documentdb-fix-private-network branch from 45769e8 to b5d1d61 Compare June 10, 2024 08:44
@jremy42 jremy42 requested a review from remyleone as a code owner June 10, 2024 09:03
@jremy42 jremy42 force-pushed the bug/documentdb-fix-private-network branch from 51a403b to f590826 Compare June 10, 2024 09:08
@remyleone remyleone changed the title Bug(documentdb): fix private network fix(documentdb): fix private network support Jun 10, 2024
@remyleone remyleone added this pull request to the merge queue Jun 10, 2024
Merged via the queue into scaleway:master with commit 9818c08 Jun 10, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scaleway_documentdb_private_network_endpoint doesn't work as expected with private_network
3 participants