From cd9d72540099bf00f8d318d019aafe84c3b6dc5d Mon Sep 17 00:00:00 2001 From: Cellie Date: Sun, 25 Oct 2020 10:28:50 +0100 Subject: [PATCH 1/2] Audio::setPinout returned a boolean 'true' even if the call to 'i2s_set_pin' fails. With this PR Audio::setPinout'i2s_set_pin' returns a 'false' if the call to 'i2s_set_pin' fails. --- src/Audio.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Audio.cpp b/src/Audio.cpp index 6b267547..43cc98ef 100644 --- a/src/Audio.cpp +++ b/src/Audio.cpp @@ -2021,8 +2021,8 @@ bool Audio::setPinout(uint8_t BCLK, uint8_t LRC, uint8_t DOUT, int8_t DIN){ .data_out_num = m_DOUT, .data_in_num = m_DIN }; - i2s_set_pin((i2s_port_t)m_i2s_num, &pins); - return true; + esp_err_t result = i2s_set_pin((i2s_port_t)m_i2s_num, &pins); + return (result == ESP_OK); } //--------------------------------------------------------------------------------------------------------------------- uint32_t Audio::getFileSize(){ From ed6ad8251fcc7ee0ee528f515e537bddfa4b11f9 Mon Sep 17 00:00:00 2001 From: Cellie Date: Sun, 25 Oct 2020 15:32:34 +0100 Subject: [PATCH 2/2] Make arg const. --- src/Audio.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Audio.cpp b/src/Audio.cpp index 43cc98ef..a9fb5b91 100644 --- a/src/Audio.cpp +++ b/src/Audio.cpp @@ -2021,7 +2021,7 @@ bool Audio::setPinout(uint8_t BCLK, uint8_t LRC, uint8_t DOUT, int8_t DIN){ .data_out_num = m_DOUT, .data_in_num = m_DIN }; - esp_err_t result = i2s_set_pin((i2s_port_t)m_i2s_num, &pins); + const esp_err_t result = i2s_set_pin((i2s_port_t)m_i2s_num, &pins); return (result == ESP_OK); } //---------------------------------------------------------------------------------------------------------------------