Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]Difficult to understand the branch of the event #2465

Closed
wahapo opened this issue May 28, 2021 · 3 comments
Closed

[Feature Request]Difficult to understand the branch of the event #2465

wahapo opened this issue May 28, 2021 · 3 comments
Labels
ui user experience Reviews for Yahoo Hack Together event

Comments

@wahapo
Copy link
Contributor

wahapo commented May 28, 2021

What happened:
When trying to start a detached job, if user accidentally select and start an event that was started from a specified branch, user will not notice the mistake.
Branch filtering

What you expected to happen:
I came up with an idea that it would be nice to have an indication of which branch an event refers to.

How to reproduce it:

@tkyi tkyi added ui user experience Reviews for Yahoo Hack Together event labels May 28, 2021
@kumada626
Copy link
Contributor

kumada626 commented Aug 11, 2021

Proposal

If the baseBranch of selected event is differ from pipeline branch, UI shows event baseBranch on event-info area like below.

スクリーンショット_2021-08-11_15_20_39

In this proposal, I think there is a discuss point like below.
  • Should UI show branch name if event baseBranch is the same branch of the pipeline branch?

To emphasis the branch is differ from pipeline branch, UI should show the branch name only if baseBranch if differ from pipeline branch.
However, the unified view is the merit of showing branch name always.

Update 2021/08/18

UI should show branch name always even if event baseBranch is the same branch of the pipeline branch.
In other word, branch name column will be added to Pipeline page.

@wahapo
Copy link
Contributor Author

wahapo commented Aug 11, 2021

@kumada626 👍
The branch name should always be visible, in my opinion. If it's not shown, it's a hassle for the user to have to look another headers to find out which branch was build.

@tkyi
Copy link
Member

tkyi commented Oct 12, 2022

bug: not sure why latest events are missing baseBranch
Screen Shot 2022-10-12 at 4 14 40 PM

idea: would be nice if branch was accurate for Pull requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui user experience Reviews for Yahoo Hack Together event
Projects
None yet
Development

No branches or pull requests

4 participants