Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current ws library generates clippy warnings #303

Closed
haerdib opened this issue Nov 8, 2022 · 1 comment · Fixed by #366
Closed

Current ws library generates clippy warnings #303

haerdib opened this issue Nov 8, 2022 · 1 comment · Fixed by #366
Assignees
@haerdib
Labels
F7-enhancement Enhances an already existing functionality Q5-involved Will take some time to fix this

Comments

@haerdib
Copy link
Contributor

haerdib commented Nov 8, 2022 •
edited
Loading

Due to the current ws library, we need to allow a lot of clippy warnings. If this library is not updated, it should be exchanged. Keep in mind: no-std option (#279)

and #267

or Box the returned Error. But it will be a breaking Api change
@haerdib haerdib added F7-enhancement Enhances an already existing functionality Q5-involved Will take some time to fix this labels Nov 8, 2022
@haerdib haerdib mentioned this issue Nov 8, 2022
Merged
@haerdib
Copy link
Contributor Author

haerdib commented Nov 8, 2022 •
edited
Loading

Alternative: https://crates.io/crates/tungstenite, https://github.com/paritytech/jsonrpsee

@haerdib haerdib mentioned this issue Nov 17, 2022
Closed
@haerdib haerdib assigned haerdib and unassigned haerdib Nov 22, 2022
@haerdib haerdib self-assigned this Nov 29, 2022
@haerdib haerdib mentioned this issue Dec 9, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haerdib haerdib

Labels
F7-enhancement Enhances an already existing functionality Q5-involved Will take some time to fix this
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add jsonrpsee as default rpc client scs/substrate-api-client
1 participant
@haerdib