dht/routes: Fix potential deadlock in FindClosestPeers

sdtsui · Jul 9, 2018 · 10855ab · 10855ab
1 parent bcd3176
commit 10855ab
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/dht/routes.go b/dht/routes.go
@@ -185,6 +185,8 @@ func (t *RoutingTable) FindClosestPeers(target peer.ID, count int) (peers []peer
 		peers = append(peers, e.Value.(peer.ID))
 	}
 
+	bucket.mutex.RUnlock()
+
 	for i := 1; len(peers) < count && (bucketID-i >= 0 || bucketID+i < len(t.self.PublicKey)*8); i++ {
 		if bucketID-i >= 0 {
 			other := t.Bucket(bucketID - i)
@@ -205,8 +207,6 @@ func (t *RoutingTable) FindClosestPeers(target peer.ID, count int) (peers []peer
 		}
 	}
 
-	bucket.mutex.RUnlock()
-
 	// Sort peers by XOR distance.
 	sort.Slice(peers, func(i, j int) bool {
 		left := peers[i].Xor(target)