Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Multiple Patterns for Each Question #10

Closed
seanprashad opened this issue May 25, 2020 · 3 comments · Fixed by #22
Closed

Allow Multiple Patterns for Each Question #10

seanprashad opened this issue May 25, 2020 · 3 comments · Fixed by #22
Labels
feature request 💬 patterns 🧩

Comments

@seanprashad
Copy link
Owner

Currently, each question is chosen to fit into a specific pattern, even if it might be applicable to other ones (ie. Some tree questions can be completed via DFS/BFS).

Original suggestion: Also, I see that currently there is only one pattern per LC problem, I would suggest we change it to an array and support multiple patterns per problem.

Originally posted by @mm1705 in #7 (comment)
@seanprashad seanprashad mentioned this issue May 25, 2020
Merged
@seanprashad seanprashad mentioned this issue Jun 3, 2020
Closed
@seanprashad
Copy link
Owner Author

Note: Double check the solution as well as Leetcode's Related Topics section to aggregate all applicable patterns for each question

@seanprashad seanprashad changed the title Allow Multiple Patterns Allow Multiple Patterns for Each Question Jun 3, 2020
@seanprashad
Copy link
Owner Author

seanprashad commented Jun 6, 2020 •
edited
Loading

This is definitely possible - see the logic introduced in #21 for generating handling multiple company names.

seanprashad pushed a commit that referenced this issue Jun 6, 2020
Allow multiple patterns per question
1868d92 
Fixes #10
@seanprashad seanprashad mentioned this issue Jun 6, 2020
Merged
seanprashad pushed a commit that referenced this issue Jun 6, 2020
Allow multiple patterns per question (#22)
2a91f1b 
* Allow multiple patterns per question

Fixes #10

* Convert pattern field to array

This update will allow multiple patterns to be added per question.

* Update Pattern column cell render to support multiple patterns
@seanprashad
Copy link
Owner Author

I've updated the functionality to allow multiple patterns per question! See below:

image

cc @mm1705 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request 💬 patterns 🧩
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow multiple patterns per question seanprashad/leetcode-patterns
1 participant
@seanprashad