Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature request - Hide Patterns for Unsolved Problems #25

Closed
ishayadav181 opened this issue Jun 8, 2020 · 3 comments · Fixed by #28
Closed

Feature request - Hide Patterns for Unsolved Problems #25

ishayadav181 opened this issue Jun 8, 2020 · 3 comments · Fixed by #28
Assignees
@seanprashad
Labels
feature request 💬

Comments

@ishayadav181
Copy link

It would be great if we can hide topic tags for unsolved problems, knowing which algorithm to use beforehand restricts the thinking process in one direction.
@seanprashad
Copy link
Owner

Hey @ishayadav181 - I like this idea!

Originally when I had put together the list (and open sourced it as the website you see now), I thought that individuals could use it in a way to "learn" a pattern, like Backtracking and then continue on studying/solving other questions. In hindsight, I didn't think that some individuals would want to keep unsolved questions hidden..

Let me investigate some ways to go about this - stay tuned!

@ishayadav181
Copy link
Author

Hi @seanprashad
You are right some people may like to practice topic wise questions. Maybe an option like Hide tags for unsolved problems will do the work. Anyway thanks for your efforts. Nice problem set !

@seanprashad seanprashad changed the title Feature request Feature request - Hide Patterns for Unsolved Problems Jun 9, 2020
@seanprashad seanprashad self-assigned this Jun 9, 2020
seanprashad pushed a commit that referenced this issue Jun 9, 2020
Hide patterns by default
434275d 
Fixes #25
@seanprashad seanprashad mentioned this issue Jun 9, 2020
Merged
seanprashad pushed a commit that referenced this issue Jun 9, 2020
Hide patterns by default (#28)
be6c0d2 
* Hide patterns by default

Fixes #25

* Remove useRef import
@seanprashad
Copy link
Owner

Hey @ishayadav181 - I had a toggle semi-working on a separate branch but there were some edge cases that I didn't fully understand (It's been awhile since I've worked in-depth with React).

As a workaround, patterns are now hidden by default, unless the respective checkbox has been checked - see below:

Showing_Checked_Question

Please let me know if you run into any problems! ✌🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seanprashad seanprashad

Labels
feature request 💬
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hide patterns by default seanprashad/leetcode-patterns
2 participants
@seanprashad @ishayadav181