Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request : Add support for drawing manager #1172

Closed
ayydevara opened this issue Sep 26, 2017 · 10 comments · Fixed by #1749
Closed

Feature Request : Add support for drawing manager #1172

ayydevara opened this issue Sep 26, 2017 · 10 comments · Fixed by #1749
Labels

Comments

@ayydevara
Copy link

Issue description
Please refer to the below url
Google Maps Drawing Libary

Steps to reproduce and a minimal demo of the problem

_Use https://plnkr.co or similar -- try this template as a starting point: http://plnkr.co/edit/YX7W20?p=preview

What steps should we try in your demo to see the problem?

Current behavior

Expected/desired behavior

angular2 & angular-google-maps version

Other information

@DiSaK74
Copy link

DiSaK74 commented Jan 22, 2018

Yes, please, it would be fantastic to have it.

@Alexandre-Herve
Copy link

Hi, I've just submitted a pull request to implement the drawing manager.

@thejustbrand
Copy link

@Alexandre-Herve , How exciting! will this get merge into production/master soon? I have a client that wants this for next week? Can I try out you pull request some how? Many thanks

@Alexandre-Herve
Copy link

@thejustbrand I use my own work from my github fork before it is merged, but the way I do it is hacky because the published npm package doesn't look like the git repo, it is the result of a build instead.

So what I have done is create a branch on the fork where the build is versionned, pull this branch from github and replace the @agm node_module files by my own files in a postinstall script. (don't try this at home ...)

So my package.json then looks like this:

    "@agm/core": "^1.0.0-beta.2",
    "@agm/snazzy-info-window": "^1.0.0-beta.2",
    "agm": "git+https://git@github.com/demainchezmoi/angular-google-maps#drawing-manager-build",

And the postinstall script like so:

"postinstall": "rm -rf node_modules/@agm ; mkdir node_modules/@agm ; mv node_modules/agm/* node_modules/@agm/"

@thejustbrand
Copy link

@Alexandre-Herve , oh i see. Probably not good for a production app then. What is the likely hood of this being merged into main AGM?
but I might give it a go in a try out locally or on a separate branch of my code base - if i can figure out how to get it running. Really excited about this!

@Alexandre-Herve
Copy link

@thejustbrand or you could build and use the built files directly in your project, bypassing npm. I have no idea, it really depends on when SebastianM will do the review, wether there will be something to fix and at what speed they release ...

@thejustbrand
Copy link

@Alexandre-Herve Ok great. I'' implement it with the 'agm' in the package.json. then I have an option and other dev can use the core version without the post install script. How do you implement your post install script/cmd?

I am more than happy to do some testing for you on this branch. I can use it to implement this new proof of concept feature we have in our app and therefore testing it out in our team. Would you mind helping me get it setup or give me some pointers to get it working?
We can discuss outside of here if easier?...

@ayydevara
Copy link
Author

Thank you @Alexandre-Herve for implementing this

@jdelgado18
Copy link

jdelgado18 commented Jul 6, 2018

Hello @Alexandre-Herve, thank you for this, I'm testing your code but I'm receiving this error: "Cannot read property 'DrawingManager' of undefined" in google-maps-api-wrapper.js line 37, the object google.maps."drawing" doesn't exist. Can you help me with that please?
¡Thanks in advanced!

@stale
Copy link

stale bot commented Nov 13, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 13, 2018
@stale stale bot closed this as completed Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants