-
Notifications
You must be signed in to change notification settings - Fork 819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request : Add support for drawing manager #1172
Comments
Yes, please, it would be fantastic to have it. |
Hi, I've just submitted a pull request to implement the drawing manager. |
@Alexandre-Herve , How exciting! will this get merge into production/master soon? I have a client that wants this for next week? Can I try out you pull request some how? Many thanks |
@thejustbrand I use my own work from my github fork before it is merged, but the way I do it is hacky because the published npm package doesn't look like the git repo, it is the result of a build instead. So what I have done is create a branch on the fork where the build is versionned, pull this branch from github and replace the @agm node_module files by my own files in a postinstall script. (don't try this at home ...) So my package.json then looks like this:
And the postinstall script like so:
|
@Alexandre-Herve , oh i see. Probably not good for a production app then. What is the likely hood of this being merged into main AGM? |
@thejustbrand or you could build and use the built files directly in your project, bypassing npm. I have no idea, it really depends on when SebastianM will do the review, wether there will be something to fix and at what speed they release ... |
@Alexandre-Herve Ok great. I'' implement it with the 'agm' in the package.json. then I have an option and other dev can use the core version without the post install script. How do you implement your post install script/cmd? I am more than happy to do some testing for you on this branch. I can use it to implement this new proof of concept feature we have in our app and therefore testing it out in our team. Would you mind helping me get it setup or give me some pointers to get it working? |
Thank you @Alexandre-Herve for implementing this |
Hello @Alexandre-Herve, thank you for this, I'm testing your code but I'm receiving this error: "Cannot read property 'DrawingManager' of undefined" in google-maps-api-wrapper.js line 37, the object google.maps."drawing" doesn't exist. Can you help me with that please? |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Issue description
Please refer to the below url
Google Maps Drawing Libary
Steps to reproduce and a minimal demo of the problem
_Use https://plnkr.co or similar -- try this template as a starting point: http://plnkr.co/edit/YX7W20?p=preview
What steps should we try in your demo to see the problem?
Current behavior
Expected/desired behavior
angular2 & angular-google-maps version
Other information
The text was updated successfully, but these errors were encountered: