Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question: why is the viewer entity coupled with other entity #11

Open
jaimesangcap opened this issue Apr 29, 2022 · 0 comments
Open

question: why is the viewer entity coupled with other entity #11

jaimesangcap opened this issue Apr 29, 2022 · 0 comments

Comments

@jaimesangcap
Copy link

jaimesangcap commented Apr 29, 2022

According to this feature-sliced page

Slices of the same layer cannot use each other directly, and their interaction and composition should be determined on the upper layer, relative to their current one

But the entities/viewer/model/hooks, refers to both wallet and book entity.

Isn't violating the principle? What is the reasoning behind the coupling?
Just curious if there is another way to tackle that particular design, like moving it to the upper layer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant