Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: Add RowDescription to SimpleQueryMessage #1143

Closed
rigby-dane opened this issue May 27, 2024 · 1 comment · Fixed by #1144
Closed

Idea: Add RowDescription to SimpleQueryMessage #1143

rigby-dane opened this issue May 27, 2024 · 1 comment · Fixed by #1144

Comments

@rigby-dane
Copy link
Contributor

Currently when processing the SimpleQueryMessage, if there are no DataRows coming from postgres the column data is inaccessible since the data is embedded in the SimpleQueryRow. In particular, this makes it difficult if you're displaying user submitted or dynamic query results where being able to determine the columns from the query after it's been sent to the server would be useful. Adding an enum value of RowDescription(Arc<[SimpleColumn]>) would alleviate this since you could separately process the columns even without a DataRow being returned.

@sfackler
Copy link
Owner

Seems reasonable to me. SimpleQueryMessage is already marked non_exhaustive so this should be a backwards compatible change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants