Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generalize top_2() by giving it a lvls parameter #17

Closed
sfirke opened this issue May 18, 2016 · 2 comments
Closed

generalize top_2() by giving it a lvls parameter #17

sfirke opened this issue May 18, 2016 · 2 comments

Comments

@sfirke
Copy link
Owner

sfirke commented May 18, 2016

instead of top_2(factor_var) it should be top_levels(factor_var, lvls = 2)
@sfirke
Copy link
Owner Author

sfirke commented May 18, 2016

This will require more care in looking at whether lvls parameter is valid given # of levels in the factor. Maybe with N levels, allow lvls to be N/2, rounded down.

@sfirke
Copy link
Owner Author

sfirke commented Jun 5, 2016

closed on the dev branch: bb4104b

@sfirke sfirke closed this as completed Jun 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sfirke