Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use getOption("OutDec") as decimal separator, fix #451 #510

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

sfirke
Copy link
Owner

@sfirke sfirke commented Jan 5, 2023

Description

Use the locale-specific value of getOption("OutDec") in adorn_pct_formatting, e.g., creates "12.34%"

Related Issue

fixed #451

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #510 (ef1040b) into main (8b7f8f0) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #510   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines         1118      1121    +3     
=========================================
+ Hits          1118      1121    +3     
Impacted Files Coverage Δ
R/adorn_pct_formatting.R 100.00% <100.00%> (ø)

@sfirke sfirke merged commit ae74366 into main Jan 10, 2023
@sfirke sfirke deleted the decimal-separator branch January 10, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature suggestion: parameter to specify decimal separator on adorn_pct_formatting
1 participant