address breaking change in dplyr::last() #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #491 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 23
Lines 1088 1088
=========================================
Hits 1088 1088
|
|
Thanks for this! We plan to release dplyr 1.1.0 on January 27. A pre-emptive fix release of janitor would be helpful. |
lionel-
reviewed
Dec 12, 2022
| @@ -91,9 +91,9 @@ adorn_percentages <- function(dat, denominator = "row", na.rm = TRUE, ...) { | |||
| if ("col" %in% attr(dat, "totals") & !explicitly_exempt_totals) { | |||
| cols_to_tally <- c(cols_to_tally, ncol(dat)) | |||
| if ("row" %in% attr(dat, "totals")) { | |||
| col_sum <- c(col_sum, sum(dplyr::last(dat)[-nrow(dat)])) | |||
| col_sum <- c(col_sum, sum(dat[-nrow(dat), ncol(dat)])) | |||
There was a problem hiding this comment.
Just FYI, another way to extract the last column with dplyr is dplyr::pull(dat).
That's the date for submission to CRAN? I appreciate the advance notice, we will plan to submit the next version of janitor to CRAN prior to that. |
yup it is
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #490