Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit janitor v2.2 to CRAN #509

Closed
7 tasks done
sfirke opened this issue Jan 4, 2023 · 10 comments
Closed
7 tasks done

Submit janitor v2.2 to CRAN #509

sfirke opened this issue Jan 4, 2023 · 10 comments
Assignees
Milestone

Comments

@sfirke
Copy link
Owner

sfirke commented Jan 4, 2023

@sfirke sfirke self-assigned this Jan 4, 2023
@sfirke sfirke added this to the v2.2 milestone Jan 4, 2023
@sfirke
Copy link
Owner Author

sfirke commented Jan 30, 2023

Eep I see dplyr 1.1.0 is released yesterday on CRAN: https://cran.r-project.org/web/packages/dplyr/index.html So right now #490 will affect users with the latest version of all packages.

I think I'm done with almost everything except some documentation. And I need to run revdep_check but don't expect that will raise any issues. I should be able to submit to CRAN this week!

@MichaelChirico
Copy link

Thanks for the update!

@sfirke
Copy link
Owner Author

sfirke commented Jan 31, 2023

revdepcheck::revdep_check() passed. Here's cran.md:

## revdepcheck results

We checked 101 reverse dependencies (98 from CRAN + 3 from Bioconductor), comparing R CMD check results across CRAN and dev versions of this package.

 * We saw 0 new problems
 * We failed to check 0 packages

@billdenney
Copy link
Collaborator

Hooray!!!

@jzadra
Copy link
Contributor

jzadra commented Jan 31, 2023

Nice work, you've been at it hard the last several weeks!

@sfirke
Copy link
Owner Author

sfirke commented Feb 1, 2023

Submitted! I'll wait to hear from CRAN and then tag the release on Github.

@sfirke
Copy link
Owner Author

sfirke commented Feb 2, 2023

Gotta fix more URL formats. Kinda funny, apparently I had this same problem when I last submitted 2 years ago:
image

@sfirke
Copy link
Owner Author

sfirke commented Feb 2, 2023

janitor 2.2.0 is live on CRAN! 馃帀

@billdenney
Copy link
Collaborator

Hooray!

@sfirke
Copy link
Owner Author

sfirke commented Feb 3, 2023

Whew. A few postmortem thoughts:

  • 馃憤 It was good that we merged the clean_names stuff a month before the release so there was time to try it out, discuss, and unwind it thoughtfully
  • 馃憥 I worked on the busiest final moments of this release on two different machines and it got me mixed up

@sfirke sfirke closed this as completed Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants