You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I ran revdep_check() and found that at least BFS and nflfastR packages are broken by the change to how duplicate names get _1, _2 etc. suffixes. That makes me inclined not to include the changes from #495 as-is for this CRAN release. I see at least these options:
Rework the code to let users allow_dupes while keeping the existing patterns of resulting names. Submit this month to CRAN, won't break other packages.
Option 1, except after 2.2 release this month so this doesn't have to be a rush job
Keep the breaking change, but delay it. Pull this PR out of the January 2023 release of 2.2, add it back to the dev branch, notify maintainers of affected packages and help them if needed.
The text was updated successfully, but these errors were encountered:
Re: #495 (comment)
I ran
revdep_check()
and found that at least BFS and nflfastR packages are broken by the change to how duplicate names get_1
,_2
etc. suffixes. That makes me inclined not to include the changes from #495 as-is for this CRAN release. I see at least these options:The text was updated successfully, but these errors were encountered: