Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to clean_names de-duplication broke existing CRAN packages #512

Closed
sfirke opened this issue Jan 16, 2023 · 2 comments
Closed

Changes to clean_names de-duplication broke existing CRAN packages #512

sfirke opened this issue Jan 16, 2023 · 2 comments

Comments

@sfirke
Copy link
Owner

sfirke commented Jan 16, 2023

Re: #495 (comment)

I ran revdep_check() and found that at least BFS and nflfastR packages are broken by the change to how duplicate names get _1, _2 etc. suffixes. That makes me inclined not to include the changes from #495 as-is for this CRAN release. I see at least these options:

  1. Rework the code to let users allow_dupes while keeping the existing patterns of resulting names. Submit this month to CRAN, won't break other packages.
  2. Option 1, except after 2.2 release this month so this doesn't have to be a rush job
  3. Keep the breaking change, but delay it. Pull this PR out of the January 2023 release of 2.2, add it back to the dev branch, notify maintainers of affected packages and help them if needed.
@sfirke
Copy link
Owner Author

sfirke commented Jan 16, 2023

Silly Github! You ate my issue, gave me a 404 error, and now I have two copies? Boo.

@sfirke sfirke closed this as completed Jan 16, 2023
@sfirke
Copy link
Owner Author

sfirke commented Jan 16, 2023

Duplicate of #513

@sfirke sfirke marked this as a duplicate of #513 Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant