Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3 to 4 (and .scss to .sass) #14

Closed
james-criscuolo opened this issue Jun 4, 2018 · 1 comment
Closed

Version 3 to 4 (and .scss to .sass) #14

james-criscuolo opened this issue Jun 4, 2018 · 1 comment

Comments

@james-criscuolo
Copy link

I'm using webpack 4.10.2 with sass-loader 6.0.7. After updating my include for the new version to have /sass, my build now fails with:

ERROR in Module build failed:
   License: none (public domain)
                                  ^
      Invalid CSS after "...blic domain) */": expected 1 selector or at-rule, was "*/ {}"
      in (myBuildPath)/node_modules/reset-css/sass/_reset.sass (line 3, column 36)

I didn't inspect the file terribly closely, but I believe the only real difference between version 3 and version 4 is that the extension changed. If I manually switch the extension back to .scss, the build succeeds.

Lastly, plugging the file into https://www.sassmeister.com/ switches the comment to look like this:

/* http://meyerweb.com/eric/tools/css/reset/
 * v4.0 | 20180602
 * License: none (public domain)

html, body, div, span, applet, object, iframe,

but then upon compile, it switches to

/* http://meyerweb.com/eric/tools/css/reset/
 * v4.0 | 20180602
 * License: none (public domain) */
html, body, div, span, applet, object, iframe,

(The comment closing characters being the important difference). Manually altering the .sass file to have this comment style ends up breaking the build further down the file (at time, mark, audio, video {), which leads me to believe the extension switch may have been by mistake.

Was the change from .scss to .sass intentional? And if so, is there anything else I should try here?

@shannonmoeller
Copy link
Owner

shannonmoeller commented Jun 4, 2018

Total bug! Thank you! Corrected back to .scss and released as v4.0.1. My apologies.

@shannonmoeller shannonmoeller changed the title Version 3 to 4 (and .scss to .sass): license causes build fail Version 3 to 4 (and .scss to .sass) Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants