Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Logical Properties #18

Closed
jlarmstrongiv opened this issue Jan 16, 2020 · 2 comments
Closed

CSS Logical Properties #18

jlarmstrongiv opened this issue Jan 16, 2020 · 2 comments

Comments

@jlarmstrongiv
Copy link

jlarmstrongiv commented Jan 16, 2020

CSS Logical Properties, such as margin-block-start, are not overridden.

Quick fix:

html, body, div, span, applet, object, iframe,
h1, h2, h3, h4, h5, h6, p, blockquote, pre,
a, abbr, acronym, address, big, cite, code,
del, dfn, em, img, ins, kbd, q, s, samp,
small, strike, strong, sub, sup, tt, var,
b, u, i, center,
dl, dt, dd, ol, ul, li,
fieldset, form, label, legend,
table, caption, tbody, tfoot, thead, tr, th, td,
article, aside, canvas, details, embed,
figure, figcaption, footer, header, hgroup,
menu, nav, output, ruby, section, summary,
time, mark, audio, video {
	margin-block-start: 0;
	margin-block-end: 0;
	padding-block-start: 0;
	padding-block-end: 0;
	border-inline-start: 0;
	border-inline-end: 0;
}
@shannonmoeller
Copy link
Owner

shannonmoeller commented Jan 24, 2020

The existing resets of border: 0;, margin: 0;, and padding: 0; appear sufficient to override these new properties. Do you have an example of a case where this is not sufficient?

Test case: https://codepen.io/shannonmoeller/pen/qBEvREV?editors=1100

@shannonmoeller
Copy link
Owner

Closing due to inactivity. Feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants