Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Perennial Self Report] Broken Oracle switchover for migration #91

Open
arjun-io opened this issue Sep 25, 2024 · 1 comment
Open

[Perennial Self Report] Broken Oracle switchover for migration #91

arjun-io opened this issue Sep 25, 2024 · 1 comment
Labels
Sponsor Confirmed The sponsor acknowledged this issue is valid Will Fix The sponsor confirmed this issue will be fixed

Comments

@arjun-io
Copy link

As part of equilibria-xyz/perennial-v2#373 we left a migration note that a shim may be required to complete the migration. After further testing the migration on forks, we found an issue with the migratioon flow where the new market implementations were calling the previous oracle implementations and expecting an updated return type ((oracleVersion, oracleReceipt)

We will need to introduce a shim to solve for this issue
@sherlock-admin3 sherlock-admin3 added Sponsor Confirmed The sponsor acknowledged this issue is valid Will Fix The sponsor confirmed this issue will be fixed labels Sep 27, 2024
@kbrizzle kbrizzle mentioned this issue Sep 29, 2024
Merged
@sherlock-admin2
Copy link

The protocol team fixed this issue in the following PRs/commits:
equilibria-xyz/perennial-v2#454

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Sponsor Confirmed The sponsor acknowledged this issue is valid Will Fix The sponsor confirmed this issue will be fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@arjun-io @sherlock-admin2 @sherlock-admin3