Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embedo dosen't work now, FB/IG seemd change the API #25

Closed
farwod opened this issue Oct 26, 2020 · 7 comments · Fixed by #26
Closed

embedo dosen't work now, FB/IG seemd change the API #25

farwod opened this issue Oct 26, 2020 · 7 comments · Fixed by #26
Labels

Comments

@farwod
Copy link

farwod commented Oct 26, 2020

hi I find fb update their API, so could you upgrade base on the new version?
FYI https://developers.facebook.com/docs/instagram/oembed-legacy/

thanks a lot

@sharafuvyt
Copy link

Please upgrade the version with the fixes

@max-dombrowski
Copy link

max-dombrowski commented Oct 27, 2020

Hi, would be very nice if you can make a new release to support the newest facebook and instagram api. Feel free to contact me if we can help.
Big thx

@tomdracz
Copy link

Looks like app id & access tokens are now required so will be higher barrier to entry. Would be happy to take a stab at PR but so far, I can't seem to get test suite to pass. Every case apart from embedding a video fails, seemingly because load event is never emitted 🤷

@shobhitsharma
Copy link
Owner

Thanks for reporting. I will look into it in evening, and update oembed URLs and specs.

@shobhitsharma
Copy link
Owner

I've tested and release new minor version for facebook and instagram embeds, only thing which needs to be done is just add access_token once to global init options as described here https://github.com/shobhitsharma/embedo/releases/tag/v1.14.0

See #26 for screenshots and changes I've made.

@shobhitsharma
Copy link
Owner

@congnk
Copy link

congnk commented Nov 19, 2020

it seem that the demo site haven't be updated?
https://shobhitsharma.github.io/embedo/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants