-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search can't handle "@" character #4058
Comments
Also fails to match |
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Still relevant. |
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Still relevant |
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Still relevant |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Still relevant |
The problem is solved by removing the "@" sign from the CharacterSet.punctuationCharacters set defined in the static function charactersToRemove in the FullTextSearchFinder.swift file. So, adding charactersToFilter.remove(charactersIn: "@") after line 101 seems to resolve the error in the search part. But the main issue here is this; There are many characters that can be used in search in Apple's punctutationCharacters. I haven't tested all of them, but it is necessary to compare them with Android and determine which ones will be included. Thanx. |
The search also fails to find "€". |
Bug description
Searching for "@" or strings containing "@" doesn't work or it doesn't show the matched messages.
Steps to reproduce
Actual result: (A) it says that no messages are found. (B) matching results don't include "@" character in the preview.
Expected result: the search engine should find any message containing "@".
Screenshots
Device info
Device: iPhone 8 Plus
iOS version: 12.1
Signal version: 2.32.0.14
Link to debug log
The text was updated successfully, but these errors were encountered: