Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search can't handle "@" character #4058

Open
3 tasks done
denver-s opened this issue Nov 22, 2018 · 11 comments
Open
3 tasks done

Search can't handle "@" character #4058

denver-s opened this issue Nov 22, 2018 · 11 comments

Comments

@denver-s
Copy link

denver-s commented Nov 22, 2018

  • I have searched open and closed issues for duplicates
  • I am submitting a bug report for existing functionality that does not work as intended
  • This isn't a feature request or a discussion topic

Bug description

Searching for "@" or strings containing "@" doesn't work or it doesn't show the matched messages.

Steps to reproduce

  • send or receive messages containing "@"
  • go to the chat list
  • (A) search for "@"
  • (B) search for a string containing "@"

Actual result: (A) it says that no messages are found. (B) matching results don't include "@" character in the preview.

Expected result: the search engine should find any message containing "@".

Screenshots

2018-11-22_17-04-43_000
2018-11-22_17-04-54_000
2018-11-22_17-05-01_000

Device info

Device: iPhone 8 Plus

iOS version: 12.1

Signal version: 2.32.0.14

Link to debug log

@nebloc
Copy link

nebloc commented Nov 28, 2018

Also fails to match . so email addresses such as example.email@server.com have to be searched like exampleemailservercom. Punctuation seems to be filtered out here.

@stale
Copy link

stale bot commented Jan 24, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Jan 24, 2022
@denver-s
Copy link
Author

Still relevant.

@stale stale bot removed the wontfix label Jan 24, 2022
@stale
Copy link

stale bot commented Mar 25, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label Mar 25, 2022
@denver-s
Copy link
Author

Still relevant

@stale stale bot removed the wontfix label Mar 25, 2022
@stale
Copy link

stale bot commented May 24, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the wontfix label May 24, 2022
@denver-s
Copy link
Author

Still relevant

@stale stale bot removed the wontfix label May 25, 2022
@stale
Copy link

stale bot commented Aug 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 31, 2022
@denver-s
Copy link
Author

Still relevant

@stale stale bot removed the stale label Aug 31, 2022
@ghost
Copy link

ghost commented Oct 26, 2022

The problem is solved by removing the "@" sign from the CharacterSet.punctuationCharacters set defined in the static function charactersToRemove in the FullTextSearchFinder.swift file. So, adding charactersToFilter.remove(charactersIn: "@") after line 101 seems to resolve the error in the search part.

But the main issue here is this; There are many characters that can be used in search in Apple's punctutationCharacters. I haven't tested all of them, but it is necessary to compare them with Android and determine which ones will be included.

Thanx.

@falkikowski
Copy link

The search also fails to find "€".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants