Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests fail with "failed to start registry" #402

Closed
jku opened this issue Oct 11, 2024 · 2 comments · Fixed by #404
Closed

tests fail with "failed to start registry" #402

jku opened this issue Oct 11, 2024 · 2 comments · Fixed by #404
Labels
bug Something isn't working

Comments

@jku
Copy link
Member

jku commented Oct 11, 2024

Description

make test fails all cosign::tests::sign_verify_image tests:

thread 'cosign::tests::sign_verify_image::case_1' panicked at src/cosign/mod.rs:573:14:
failed to start registry: Client(Init(SocketNotFoundError("/var/run/docker.sock")))
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Do tests need docker daemon to run? This does not seem to be documented anywhere...

Version

current git main (e536360).

@jku jku added the bug Something isn't working label Oct 11, 2024
@flavio
Copy link
Member

flavio commented Oct 11, 2024

Yes, it does require the docker daemon to be running. We're using testcontainers for that.

Would you mind adding a note about that into... I just realized we don't have a CONTRIBUTING.md file or something like that 😢

@jku
Copy link
Member Author

jku commented Oct 11, 2024

yes, confirmed things work if docker daemon is running and user has permissions to start a container

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants