Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling pushgaetway functions still requires passing 2 arguments (args and callback) #468

Closed
Landria opened this issue Sep 29, 2021 · 3 comments
Closed

Calling pushgaetway functions still requires passing 2 arguments (args and callback) #468

Landria opened this issue Sep 29, 2021 · 3 comments

Comments

@Landria
Copy link

Landria commented Sep 29, 2021

Pushgateway got promisified In v14.0.0, but it still requires a callback when you call it.
It comes from here:

prom-client/index.d.ts

Line 564 in 5c1c68e

callback: (error?: Error, httpResponse?: any, body?: any) => void,

@Landria Landria changed the title Calling pushgaetway functions still require passing 2 arguments (args and callback) Calling pushgaetway functions still requires passing 2 arguments (args and callback) Sep 29, 2021
@SimenB
Copy link
Collaborator

SimenB commented Sep 29, 2021

Wanna send a PR fixing it? 🙂

@miclud
Copy link

miclud commented Oct 21, 2021

Wasn't this fixed in #469?
Still yet to be released though ref. #473

@SimenB SimenB closed this as completed Nov 3, 2021
@SimenB
Copy link
Collaborator

SimenB commented Nov 3, 2021

https://github.com/siimon/prom-client/releases/tag/v14.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Landria @miclud @SimenB