From e8bfe4a7381a79b525e4d9814a6b58aaf181401a Mon Sep 17 00:00:00 2001
From: Danny Rorabaugh <imnasnainaec@gmail.com>
Date: Fri, 3 Nov 2023 14:29:57 -0400
Subject: [PATCH] Remove extra ! and tidy

---
 src/components/Login/Signup.tsx            | 6 ++----
 src/components/Login/tests/Signup.test.tsx | 5 +++--
 2 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/src/components/Login/Signup.tsx b/src/components/Login/Signup.tsx
index 46dc3d582a..3f20468023 100644
--- a/src/components/Login/Signup.tsx
+++ b/src/components/Login/Signup.tsx
@@ -135,7 +135,7 @@ export default function Signup(props: SignupProps): ReactElement {
       [SignupField.Username]: !meetsUsernameRequirements(username),
       [SignupField.Email]: !email,
       [SignupField.Password1]: !meetsPasswordRequirements(password1),
-      [SignupField.Password2]: password1 !== password2!,
+      [SignupField.Password2]: password1 !== password2,
     };
 
     if (Object.values(err).some((e) => e)) {
@@ -255,9 +255,7 @@ export default function Signup(props: SignupProps): ReactElement {
               <Grid item>
                 <Button
                   id={SignupId.ButtonLogIn}
-                  onClick={() => {
-                    router.navigate(Path.Login);
-                  }}
+                  onClick={() => router.navigate(Path.Login)}
                   type="button"
                   variant="outlined"
                 >
diff --git a/src/components/Login/tests/Signup.test.tsx b/src/components/Login/tests/Signup.test.tsx
index bf099fa529..b12429a002 100644
--- a/src/components/Login/tests/Signup.test.tsx
+++ b/src/components/Login/tests/Signup.test.tsx
@@ -35,8 +35,9 @@ jest.mock("types/hooks", () => {
 });
 
 const mockAsyncSignUp = jest.fn();
-const mockChangeEvent = (text: string): ChangeEvent =>
-  ({ target: { value: text } }) as any as ChangeEvent;
+const mockChangeEvent = (text: string): Partial<ChangeEvent> => ({
+  target: { value: text } as HTMLTextAreaElement | HTMLInputElement,
+});
 const mockFormEvent: Partial<FormEvent> = { preventDefault: jest.fn() };
 const mockStore = configureMockStore()({ loginState });