Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable nullable compiler option on BackendTests project #850

Closed
johnthagen opened this issue Dec 4, 2020 · 0 comments · Fixed by #881
Closed

Enable nullable compiler option on BackendTests project #850

johnthagen opened this issue Dec 4, 2020 · 0 comments · Fixed by #881
Assignees
@johnthagen
Labels
backend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. test

Comments

@johnthagen
Copy link
Collaborator

johnthagen commented Dec 4, 2020 •
edited
Loading

Currently, the nullable compiler option is only enabled on the make Backend project, not the test project. This means there are slight differences in the API's exposed by the Backend and what is used in tests. Ideally, nullable should be enabled for the test project as well to better sync them at the type system level.

Follow on to #754
@johnthagen johnthagen added backend test maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. labels Dec 4, 2020
@johnthagen johnthagen self-assigned this Dec 4, 2020
@johnthagen johnthagen mentioned this issue Dec 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnthagen johnthagen

Labels
backend maintenance Issue that makes it difficult to maintain the software or to upgrade installations post-release. test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use nullable compiler option for backend test project sillsdev/TheCombine
1 participant
@johnthagen