From 647d85d7ad9989a09346ea22e1db7d36b501154b Mon Sep 17 00:00:00 2001
From: Eberhard Beilharz <eb1@sil.org>
Date: Mon, 3 Jan 2022 19:45:45 +0100
Subject: [PATCH] Modernize icu.net.csproj

- Use generated assembly info
- remove obsolete limitations
---
 source/icu.net/Properties/AssemblyInfo.cs | 28 -----------------------
 source/icu.net/icu.net.csproj             | 20 ++++------------
 2 files changed, 4 insertions(+), 44 deletions(-)
 delete mode 100644 source/icu.net/Properties/AssemblyInfo.cs

diff --git a/source/icu.net/Properties/AssemblyInfo.cs b/source/icu.net/Properties/AssemblyInfo.cs
deleted file mode 100644
index 9789992a..00000000
--- a/source/icu.net/Properties/AssemblyInfo.cs
+++ /dev/null
@@ -1,28 +0,0 @@
-// Copyright (c) 2007-2017 SIL International
-// This software is licensed under the MIT license (http://opensource.org/licenses/MIT)
-using System;
-using System.Reflection;
-using System.Runtime.InteropServices;
-
-// General Information about an assembly is controlled through the following
-// set of attributes. Change these attribute values to modify the information
-// associated with an assembly.
-[assembly: AssemblyTitle("icu.net")]
-[assembly: AssemblyDescription("")]
-[assembly: AssemblyConfiguration("")]
-[assembly: AssemblyCompany("SIL International")]
-[assembly: AssemblyProduct("icu.net")]
-[assembly: AssemblyCopyright("Copyright © SIL International 2007-2018")]
-[assembly: AssemblyTrademark("")]
-[assembly: AssemblyCulture("")]
-
-// Setting assembly to CLS compliant so that it can be used on any other .NET languages.
-[assembly: CLSCompliant(true)]
-
-// Setting ComVisible to false makes the types in this assembly not visible
-// to COM components.  If you need to access a type in this assembly from
-// COM, set the ComVisible attribute to true on that type.
-[assembly: ComVisible(false)]
-
-// The following GUID is for the ID of the typelib if this project is exposed to COM
-[assembly: Guid("3439151b-347b-4321-9f2f-d5fa28b46477")]
diff --git a/source/icu.net/icu.net.csproj b/source/icu.net/icu.net.csproj
index 35f728f5..9688b951 100644
--- a/source/icu.net/icu.net.csproj
+++ b/source/icu.net/icu.net.csproj
@@ -11,7 +11,7 @@
     <Authors>SIL International</Authors>
     <PackageLicenseExpression>MIT</PackageLicenseExpression>
     <PackageProjectUrl>https://github.com/sillsdev/icu-dotnet</PackageProjectUrl>
-    <Copyright>Copyright © 2007-2021 SIL International</Copyright>
+    <Copyright>Copyright © 2007-2022 SIL International</Copyright>
     <Description>icu.net is a C# Wrapper around ICU4C
 
 This version of icu.net works with (more or less) any version of ICU4C.
@@ -20,30 +20,18 @@ NOTE: this package contains the managed wrapper part of icu.net. You'll also hav
     <AppendToReleaseNotesProperty><![CDATA[
 See full changelog at https://github.com/sillsdev/icu-dotnet/blob/master/CHANGELOG.md.]]>
     </AppendToReleaseNotesProperty>
-    <GenerateAssemblyCompanyAttribute>false</GenerateAssemblyCompanyAttribute>
-    <GenerateAssemblyConfigurationAttribute>false</GenerateAssemblyConfigurationAttribute>
-    <GenerateAssemblyCopyrightAttribute>false</GenerateAssemblyCopyrightAttribute>
-    <GenerateAssemblyDescriptionAttribute>false</GenerateAssemblyDescriptionAttribute>
-    <GenerateAssemblyProductAttribute>false</GenerateAssemblyProductAttribute>
-    <GenerateAssemblyTitleAttribute>false</GenerateAssemblyTitleAttribute>
     <ChangelogFile>../../CHANGELOG.md</ChangelogFile>
     <IncludeSymbols>true</IncludeSymbols>
     <SymbolPackageFormat>snupkg</SymbolPackageFormat>
     <LangVersion>7.1</LangVersion>
+    <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
+    <SignAssembly>true</SignAssembly>
+    <AssemblyOriginatorKeyFile>icu.net.snk</AssemblyOriginatorKeyFile>
   </PropertyGroup>
   <!-- Full .NET Framework properties -->
   <PropertyGroup Condition="'$(TargetFramework)' != 'netstandard1.6'">
     <DefineConstants>$(DefineConstants);FEATURE_ICLONEABLE</DefineConstants>
   </PropertyGroup>
-  <!-- Using Mono msbuild with .NET Core build targets does not support
-  assembly signing, yet. -->
-  <PropertyGroup Condition="'$(OS)'=='Windows_NT'">
-    <SignAssembly>true</SignAssembly>
-    <AssemblyOriginatorKeyFile>icu.net.snk</AssemblyOriginatorKeyFile>
-  </PropertyGroup>
-  <PropertyGroup>
-    <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
-  </PropertyGroup>
   <ItemGroup Condition="'$(TargetFramework)' == 'netstandard1.6'">
     <PackageReference Include="System.Diagnostics.TraceSource" Version="4.3.0" />
     <PackageReference Include="System.Runtime.InteropServices.RuntimeInformation" Version="4.3.0" />