-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add health check for SMT engine disk storage #141
Comments
I would like to keep this open. It doesn't seem right to me that we return a "healthy" status from the health check endpoint when SMT suggestions do not work, because of low/no disk space. |
One option is to have "degraded" if we are getting GRPC errors (which we were) and keep it on for 30 minutes or so... |
It would be easier to just check the disk space, especially since there is already a health check library that can do it. |
Ok - it will be a redundant check, but I can see the value. |
In order to use this health check, we have to reference a specific drive by string (e.g. "C://"). How will this work in containers? Is this workable, @johnml1135? |
I am assuming that the main paths
and
|
There is no health check for low disk storage. If the disk storage gets too low, then SMT engines will be negatively impacted. We can use DiskStorageHealthCheck from the AspNetCore.HealthChecks.System library.
The text was updated successfully, but these errors were encountered: