Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When USFM verses are merged, the non-verse content between it gets appended as well #475

Open
johnml1135 opened this issue Sep 4, 2024 · 8 comments
Assignees
Labels
bug Something isn't working sf_watching Scripture Forge should be updated when this is resolved or updated

Comments

@johnml1135
Copy link
Collaborator

johnml1135 commented Sep 4, 2024

  {
    "corpusId": "66c646dd2c3a820e41266b86",
    "textId": "GEN",
    "refs": [
      "GEN 1:1",
      "GEN 1:1/1:f",
      "GEN 1:2"
    ],
    "translation": "En el principio, Dios cre\u00F3 los cielos y la tierra. 1:1 O En el principio, cuando Dios cre\u00F3 los cielos y la tierra... o Cuando Dios comenz\u00F3 a crear los cielos y la tierra... La tierra no ten\u00EDa forma y estaba vac\u00EDa, y la oscuridad cubr\u00EDa las aguas profundas; y el Esp\u00EDritu de Dios se mov\u00EDa en el aire sobre la superficie de las aguas."
  },

We are globbing together v1 and v2 along with the footnote and putting it all into one segment. Why?

@johnml1135 johnml1135 added the bug Something isn't working label Sep 4, 2024
@johnml1135
Copy link
Collaborator Author

johnml1135 commented Sep 4, 2024

This is from the NTV resource - here is the relevant USFM:

\mt1
Génesis
\c 1
\s1
El relato de la creación
\m
\v 1 En el principio, Dios creó los cielos y la tierra.\f * \fr 1:1 \ft O \fqa En el principio, cuando Dios creó los cielos y la tierra... \ft o \fqa Cuando Dios comenzó a crear los cielos y la tierra...\f* \v 2 La tierra no tenía forma y estaba vacía, y la oscuridad cubría las aguas profundas; y el Espíritu de Dios se movía en el aire sobre la superficie de las aguas.

What's with all the \f *?

@ddaspit
Copy link
Contributor

ddaspit commented Sep 4, 2024

What is the source USFM?

@Nateowami
Copy link
Collaborator

@ddaspit John has posted it above. The source project is NTV.

@Nateowami
Copy link
Collaborator

I have more details. The original target USFM had v1 and v2 combined. I uncombined them and ran the draft again, and it correctly output this:

\v 1 In the beginning God created the heavens and the earth. \f * \ft 1:1 Or in the beginning, when God created the heavens and the earth... or when God began to create the heavens and the earth...\f*
\v 2 And the earth was formless and void, and darkness was upon the face of the deep; and the Spirit of God was hovering over the face of the waters.

It appears to me that the bug has to do with trying to follow the target project's USFM and/or versification, which it shouldn't be doing.

@Nateowami Nateowami added the sf_watching Scripture Forge should be updated when this is resolved or updated label Sep 4, 2024
@johnml1135
Copy link
Collaborator Author

When it is pretranslated, we don't know whether we will want to insert it into the source or the target and we combine the versifications, hence merging v1 and v2. The real issue in my mind is that when we combine those verses, we also merge in the non-verse content. That should not be the case - I will update the issue to reflect that.
@Nateowami, if you still think it should not merge the verses, please open up a new issue and we can discuss it further.

@johnml1135 johnml1135 changed the title USFM parsing globbing things together when they shouldn't When USFM verses are merged, the non-verse content between it gets appended as well Sep 4, 2024
@Enkidu93
Copy link
Collaborator

It's not clear to me, @johnml1135 / @ddaspit, what the intended behavior is here. You're just saying, John, that you ought to have the ref GEN 1:1/1:f with its own pretranslation but 1 and 2 ought to still be merged?

@ddaspit
Copy link
Contributor

ddaspit commented Oct 15, 2024

@Enkidu93 Yes, that is correct.

@Enkidu93
Copy link
Collaborator

@Enkidu93 Yes, that is correct.

Ok, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sf_watching Scripture Forge should be updated when this is resolved or updated
Projects
Status: 🆕 New
Development

No branches or pull requests

4 participants