Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering on pretranslations not working! #514

Open
johnml1135 opened this issue Oct 16, 2024 · 3 comments
Open

Filtering on pretranslations not working! #514

johnml1135 opened this issue Oct 16, 2024 · 3 comments
Assignees

Comments

@johnml1135
Copy link
Collaborator

We're putting all verses into pretranslate.src.json! This is causing issues.

@johnml1135 johnml1135 self-assigned this Oct 16, 2024
@johnml1135
Copy link
Collaborator Author

@Enkidu93 - also, if a corpora is specified for pretranslation or training, then all other corpora should not be used. Currently I believe the logic is "use all". This is unintuitive.

@Enkidu93
Copy link
Collaborator

@Enkidu93 - also, if a corpora is specified for pretranslation or training, then all other corpora should not be used. Currently I believe the logic is "use all". This is unintuitive.

@johnml1135, that could be unintuitive, I agree. Wasn't that how it already worked though with the non-parallel corpora? I think it was conceived of more as specifying a set of filters that operate on all of the associated corpora than positively specifying all data; is that right?

@johnml1135
Copy link
Collaborator Author

Multi-corpora filtering moved to #516.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants