From d04231e7efc02c321587808957d73882e6ab599a Mon Sep 17 00:00:00 2001 From: Tim Haasdyk Date: Thu, 20 Oct 2022 12:09:15 +0200 Subject: [PATCH] Rework Makefile to remove npm-ci target This seems cleaner than having a target for a single command $(MAKE) is the recommended way rather than simply make --- Makefile | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index f3620bde96..9a1cb4e149 100644 --- a/Makefile +++ b/Makefile @@ -10,10 +10,14 @@ dev: start docker compose up -d ui-builder .PHONY: playwright-tests-ci -playwright-tests-ci: npm-ci playwright-tests +playwright-tests-ci: + npm ci + $(MAKE) playwright-tests .PHONY: playwright-tests playwright-tests: + npm install + # stop any containers that are running docker compose down @@ -71,10 +75,6 @@ next-dev: build build-next: docker compose build next-proxy next-app -.PHONY: npm-ci -npm-ci: - npm ci - .PHONY: clean clean: docker compose down