From 2575b8ec65f680a22a666fcc517e038f3ad75b9a Mon Sep 17 00:00:00 2001 From: Chris Cowan Date: Fri, 28 Jul 2017 06:51:16 -0700 Subject: [PATCH] Fixes #13181 - Check values before adding them to filter --- .../kibana/public/dashboard/dashboard_context.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/core_plugins/kibana/public/dashboard/dashboard_context.js b/src/core_plugins/kibana/public/dashboard/dashboard_context.js index 5788905f58ed6c..1824ba3f21bd03 100644 --- a/src/core_plugins/kibana/public/dashboard/dashboard_context.js +++ b/src/core_plugins/kibana/public/dashboard/dashboard_context.js @@ -13,7 +13,8 @@ export function dashboardContextProvider(Private, getAppState) { if (queryBarQuery.language === 'lucene') { // Add the query bar filter, its handled differently. - bool.must.push(luceneStringToDsl(queryBarQuery.query)); + const query = luceneStringToDsl(queryBarQuery.query); + if (query) bool.must.push(query); } // Add each of the filter bar filters @@ -26,10 +27,10 @@ export function dashboardContextProvider(Private, getAppState) { if (filter.meta.disabled) return; if (filter.meta.negate) { bool.must_not = bool.must_not || []; - bool.must_not.push(esFilter.query || esFilter); + if (esFilter.query || esFilter) bool.must_not.push(esFilter.query || esFilter); } else { bool.must = bool.must || []; - bool.must.push(esFilter.query || esFilter); + if (esFilter.query || esFilter) bool.must.push(esFilter.query || esFilter); } });