Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serial command getDiscType() may cause issues with CD capable players. #152

Open
dude22072 opened this issue Dec 12, 2023 · 0 comments
Open

Comments

@dude22072
Copy link

On players with a CD tray, if the ?D command is sent while a CD/CDV/VSD is inserted it will return the error E04, however the PlayerCommunication::getDiscType() is simply checking if the second byte is 0/1, meaning that the capture app will incorrectly think a CAV Laserdisc is inserted.
Furthermore these players have a separate ?K status command, where the 4th byte will be 0 for a CD or 1 for a CDV (and presumably VSD as well). Complementary to ?D this ?K command will return E04 if a laserdisc is inserted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant