-
-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Got doesn't throw on leading slashes #1057
Labels
Comments
szmarczak
added
bug
Something does not work as it should
✭ help wanted ✭
regression
Something does not work anymore
labels
Feb 8, 2020
szmarczak
changed the title
Got doesn't deduplicate leading slashes
Got doesn't throw on leading slashes
Feb 8, 2020
I don't think it should throw if const myApi = got.extend({ prefixUrl: 'https://api.example.com' });
myApi.get('/things'); // this should be fine as it is not ambiguous. |
@azz The readme says that the ending |
That's what's currently documented but I'm challenging whether that behaviour is appropriate, especially in the case where it is non-ambiguous. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
As per the readme:
But it does not throw:
got/source/normalize-arguments.ts
Lines 303 to 319 in 3c6ca29
The text was updated successfully, but these errors were encountered: