Skip to content
This repository has been archived by the owner on May 16, 2024. It is now read-only.

Responsive check isn't correct #18

Open
soulgalore opened this issue Feb 23, 2016 · 3 comments
Open

Responsive check isn't correct #18

soulgalore opened this issue Feb 23, 2016 · 3 comments

Comments

@soulgalore
Copy link
Member

The way we check if a page is responsive isn't correct:
https://github.com/sitespeedio/coach/blob/master/lib/dom/info/responsive.js

It will only work if the width of the browser window is small, then it's correct. Would be cool of course to know this even when the browser window width is bigger.

@soulgalore
Copy link
Member Author

We should validate and check if this is still true. Is it a better way of doing this?

@sumeetrohra
Copy link
Contributor

@soulgalore we can use the same check for multiple viewports, then even if 1 of them is not responsive, the site is not responsive, that should work. Should I start doing that?

@soulgalore
Copy link
Member Author

No I think we don't wanna change the viewport since it potentially could trigger other things (like downloading images that before was out of viewport but now become within the viewport). Maybe there are no good way of doing this, then I guess we can skip it,

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants