Skip to content
This repository has been archived by the owner on May 16, 2024. It is now read-only.

[compressAssets] Avoid double-compression #301

Open
znerd opened this issue Oct 5, 2018 · 1 comment
Open

[compressAssets] Avoid double-compression #301

znerd opened this issue Oct 5, 2018 · 1 comment
Labels
good first issue

Comments

@znerd
Copy link

znerd commented Oct 5, 2018 •
edited
Loading

Currently the compressAssets rule indicates that I should compress WOFF2 files. Since WOFF2 files are already compressed, I don't think that is appropriate advice.

In fact I would suggest inverting the rule, and validate that already compressed files (WOFF2, GZIP, to name a few) are indeed not compressed again.

Context:

  • SiteSpeed.io 7.4.0 (with Coach 2.2.0)
@znerd znerd changed the title [compressAssets] WOFF2 files are better served uncompressed [compressAssets] Avoid double-compression Oct 5, 2018
@soulgalore
Copy link
Member

Hi @znerd yeah. Do you have time to do a PR? I'm planning to rework the advice late October or late November, but before that I will focus on getting the next sitespeed.io release out there.

Best
Peter

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@znerd @soulgalore