fix vicuna example #2173
Merged
fix vicuna example #2173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michaelvll
reviewed
Jul 4, 2023
Comment on lines
+13
to
+27
| if [ "${local_last_ckpt}" != "${remote_last_ckpt}" ]; then | ||
| mkdir -p ${remote_path}/${local_last_ckpt} | ||
| gsutil -m rsync -r ${local_path}/${local_last_ckpt}/ ${remote_path}/${local_last_ckpt} | ||
|
|
||
| # Keep only the last MAX_NUM_CKPT checkpoints | ||
| num_local_ckpt=$(ls ${local_path} | grep checkpoint- | wc -l) | ||
| echo "num_local_ckpt: ${num_local_ckpt}" | ||
| if [ ${num_local_ckpt} -gt $MAX_NUM_CKPT ]; then | ||
| for ckpt in $(ls ${local_path} | grep checkpoint- | grep -E '[0-9]+' | sort -t'-' -k1,1 -k2,2n | head -n-${MAX_NUM_CKPT}); do | ||
| rm -rf ${local_path}/${ckpt} | ||
| done | ||
| fi | ||
| fi | ||
|
|
||
| sleep 600 |
There was a problem hiding this comment.
Should we upload the whole local directories anyway or do you think we still need this uploading last checkpoint logic?
Michaelvll
approved these changes
Jul 10, 2023
|
Sorry I didn't get time to further improve this. Let's fix it first and hopefully we have a more robust sync mode by @landscapepainter's #2190. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested (run the relevant ones):
bash format.shpytest tests/test_smoke.pypytest tests/test_smoke.py::test_fill_in_the_namebash tests/backward_comaptibility_tests.sh