Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Todo List Items Can Be Checked/Unchecked with Quill Disabled #1312

Closed
danielschwartz opened this issue Feb 10, 2017 · 4 comments
Closed

Todo List Items Can Be Checked/Unchecked with Quill Disabled #1312

danielschwartz opened this issue Feb 10, 2017 · 4 comments

Comments

@danielschwartz
Copy link

If Quill is in readOnly mode (either by supplying readOnly: true1) in the constructor, or by doing quill.disable()` todo list items can still be checked/unchecked

Steps for Reproduction

  1. Create a readOnly Quill instance with todo list items

Expected behavior:
With the editor in the disabled state you should not be able to modify it's contents.

Actual behavior:
With the editor disabled, the todo list item click handler doesn't check if quill is disabled, so it's possible to check/uncheck items

Version:
v.1.2.0

Solution
It doesn't seem like the quill instance is available at the blot level, but it would be fairly trivial to check if it was disabled in the click handler if it was.

@sferoze
Copy link
Contributor

sferoze commented Feb 22, 2017

@danielschwartz

ive been looking through the docs and cannot find any support for Todo List Checkbox items. I search other issues and I see it's currently a work in progress.

Are you using a specific plugin? If you are and it is something I can take a look at, please let me know. I am looking to integrate this feature.

As this comment may be off topic for this thread I will eventually delete it.

@jhchen jhchen closed this as completed in 9536875 Feb 26, 2017
@jhchen
Copy link
Member

jhchen commented Feb 26, 2017

@sferoze The current status is on this issue #759

@akhilaudable
Copy link

Any progress in this?

@szymonlisiecki
Copy link

any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants