Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quill Bubble Toolbar on iOS/Mobile does not work well #1396

Closed
sferoze opened this issue Apr 9, 2017 · 3 comments
Closed

Quill Bubble Toolbar on iOS/Mobile does not work well #1396

sferoze opened this issue Apr 9, 2017 · 3 comments

Comments

@sferoze
Copy link
Contributor

sferoze commented Apr 9, 2017

Tested on iOS device but might also apply to all mobile devices. These issues are seen in the quill example editors.

When using the bubble theme and after selecting some text the toolbar does not show right away. After selecting text, you have to scroll the window a tad bit, and then the quill toolbar shows.
Then once the toolbar is shown, the first time you select a formatting button, the text does not get formatted, the selection disappears but the toolbar stays open, and the selection collapses to blinking cursor.

Since the toolbar is still open you can try tapping the formatting button again, and this time the text does get formatted. And the selection re-selects the text that collapsed after the first tap.

Just try using the bubble toolbar on an iOS device you will notice all these issues when trying any formatting command like Bold.

Steps for Reproduction

  1. Visit https://quilljs.com/playground/#autogrow-height on an iOS device
  2. Select some text
  3. Attempt to format the selected text with the quill toolbar that is suppose to show

Expected behavior:

The toolbar should show itself after selecting text, and format the text on the first tap of any formatting button.

Actual behavior:

All the issues described above...

Platforms:

iOS

Version:

Quill 1.2.3

@jhchen
Copy link
Member

jhchen commented May 29, 2017

There seems to be two issues described here:

  1. The toolbar does not always show up when a selection is made
  2. With a selection and toolbar shown, touching a format button like bold does not apply the formatting.

I've never been able to produce 1) so more guidance on here would be helpful. On 2) it seems to be largely a case of the touch target not being very large for mobile devices. To confirm this every time it does work you should see the button darken for a split second (indicating the button press). If not that means your finger missed the button. Another way to check this is just to make the button a lot bigger.

@jhchen
Copy link
Member

jhchen commented Jul 17, 2017

Quill now uses selectionchange in 1.3.0 which should always accurately update the selection which may cause 1. Please try on the latest version to see if it is fixed.

@sferoze
Copy link
Contributor Author

sferoze commented Jul 18, 2017

@jhchen The toolbar pops up nicely and works as expected on mobile! I had tested on an iOS device. Thanks!

@sferoze sferoze closed this as completed Jul 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants