Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Tooltip - 'editing' class still present when tooltip is blurred #449

Closed
magus opened this issue Aug 12, 2015 · 3 comments
Closed

Link Tooltip - 'editing' class still present when tooltip is blurred #449

magus opened this issue Aug 12, 2015 · 3 comments

Comments

@magus
Copy link

magus commented Aug 12, 2015

On blur the editing class should be removed from the tooltip, the hide margin is correctly applied but we should also remove the editing class. I've made this fix locally and can probably whip up a PR but just filing this for the record.

@jhchen
Copy link
Member

jhchen commented Aug 12, 2015

Why is this a bug? The editing class is to control if a textbox to edit a link or link itself is visible. The margin is to show/hide the entire tooltip--two orthogonal purposes.

@magus
Copy link
Author

magus commented Aug 13, 2015

Sort of related to the other bug, I think it's more clear if the editing class is removed when we are no longer showing the tooltip. I use the presence of the editing class to show/hide the tooltip since I'm overriding the absolute positioning (static location instead of tooltip). Feel free to close this, I think I'm almost done just working around things.

@jhchen
Copy link
Member

jhchen commented Aug 13, 2015

Closing as this is not the purpose of the editing class.

@jhchen jhchen closed this as completed Aug 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants