Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for prom-client v14 #147

Closed
leedm777 opened this issue Nov 15, 2021 · 1 comment
Closed

Add support for prom-client v14 #147

leedm777 opened this issue Nov 15, 2021 · 1 comment
Assignees

Comments

@leedm777
Copy link

The prom-client module released v14 on Sept 18. Please update swagger-stats to allow for the upgrade. The breaking changes in the prom-client release are:

  • changed: linearBuckets does not propagate rounding errors anymore.

    Fewer bucket bounds will be affected by rounding errors. Histogram bucket
    labels may change. 6f1f3b2

  • changed: The push gateway methods pushAdd(), push() and delete() now
    return Promises instead of accepting a callback:

    // Old:
    gateway.pushAdd({ jobName: 'test' }, (err, resp, body) => {});
    // New:
    gateway
      .pushAdd({ jobName: 'test' })
      .then(({ resp, body }) => {})
      .catch(err => {});
    // or
    const { resp, body } = await gateway.pushAdd({ jobName: 'test' });

    f177b1f

  • changed: The default nodejs_eventloop_lag_* metrics are now reset every time
    they are observed. This prevents these metrics from "stabilizing" over a long
    period of time and becoming insensitive to small changes. For more info, see
    #370. 0f444cd

@sv2 sv2 self-assigned this Nov 16, 2021
@sv2
Copy link
Collaborator

sv2 commented Dec 8, 2022

v0.99.3

@sv2 sv2 closed this as completed Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants