-
-
Notifications
You must be signed in to change notification settings - Fork 697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker-slim version 1.25.0 fails running in gitlab #75
Comments
@khassel thank you for reporting the issue! Can you run it with the debug flag ( |
no changes with This is my
Job fails with exit code 1, if you use the version 1.24.2 everything is fine. |
Thanks for the config file! It'll help with the repro! |
1.25.0 appears to fail when it's trying to access /dev/tty, which 1.24.2 isn't doing... |
o.k., thats the problem, gitlab ci does not support tty (you can google "gitlab tty").
The last option needs the
|
This ended up being pulled in as an indirect dependency for the update download progress bar. It's using github.com/gosuri/uiprogress for it, which pulls in github.com/gosuri/uilive. The uilive library is the reason docker-slim exits because it calls os.Exit when it can't open /dev/tty, which no sane library should ever do... The progress bar was a nice touch, but it's definitely not worth this headache. I'll remove it in the next minor release. |
@khassel can you try this 'temporary' release package to see if it works for you https://github.com/docker-slim/docker-slim/releases/download/1.25.0/dist_linux_1.25.1.tar.gz (the version command worked in my test gitlab setup, but i'm curious if it works well for your actual project). |
works with my test-setup 👍
|
@khassel good to hear that :) I'm curious about your use cases... Is smaller docker images the main value you are looking for? Are you interested in the seccomp profiles too? Is there anything else you would like to do with your containers using this tool or possibly something else? |
o.k., here one of the real use cases: https://gitlab.com/khassel/alexa_sdk_docker/blob/master/.gitlab-ci.yml |
@khassel thanks for the reference! I assume you don't have an http service running there and if it's the case you don't need the http-probe parameter in you gitlab-ci file. |
@kcq Can we also get the arm release of 1.25.1? I have encountered the exact same issue in my pipelines. |
Definitely @jishminor Will do an official 1.25.2 with a few other wrapped up enhancements in the next couple of days. 1.26 is taking a bit longer than expected. |
solved by 1.25.2. |
Using docker-slim within gitlab ci was no problem with version 1.24.2. With 1.25.0 running
docker-slim version
fails with no error message (and no output).The text was updated successfully, but these errors were encountered: