From 85d3f447c14c1986876451df6f77c06fead01a57 Mon Sep 17 00:00:00 2001 From: Shaun Smith Date: Thu, 15 Mar 2018 13:46:20 +0000 Subject: [PATCH] fix: prevent crash when editable fragment references a tag - fragment parser was crashing on things like `#egg=simple==v1.0.0` --- plug/requirements/fragment.py | 4 +++- test/workspaces/pip-app-deps-editable/requirements.txt | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/plug/requirements/fragment.py b/plug/requirements/fragment.py index a89f7a6d..4a4c0b19 100644 --- a/plug/requirements/fragment.py +++ b/plug/requirements/fragment.py @@ -1,3 +1,5 @@ +# MODIFIED - Replace/Update with care + import re # Copied from pip @@ -14,7 +16,7 @@ def parse_fragment(fragment_string): try: return dict( - key_value_string.split('=') + key_value_string.split('==')[0].split('=') for key_value_string in fragment_string.split('&') ) except ValueError: diff --git a/test/workspaces/pip-app-deps-editable/requirements.txt b/test/workspaces/pip-app-deps-editable/requirements.txt index 6552dbee..ad6700d4 100644 --- a/test/workspaces/pip-app-deps-editable/requirements.txt +++ b/test/workspaces/pip-app-deps-editable/requirements.txt @@ -1,3 +1,3 @@ --e git+https://github.com/snyk-fixtures/python-pypi-package-simple#egg=simple +git+https://github.com/snyk-fixtures/python-pypi-package-simple@v1.0.0#egg=simple==v1.0.0 -e git+https://github.com/snyk-fixtures/python-pypi-package-sample-subdir#egg=sample&subdirectory=subdir posix_ipc==1.0.0